reply to Osirusdatank
Re: Warrior advice for 4.3????? Heroic Strike is filler. Yes, it's a damage ability, but a) it's off the global cooldown and b) if you are at 100 rage, any more you would gain is wasted resources. Why waste the huge amount of AP you get through Vengeance? There have been times where a raid needs that little bit more dps to beat an enrage timer - or at least survive a fight with everyone up.
Which leads to your second point - generating a lot of rage is useless if you're not using it efficiently. Besides, there are quite a few bosses where you know you're going to get hit hard (soaking Hour of Twilight on Ultraxion, Psychic Drain/Black Blood of Go'rath on Zon'ozz, Morchok's Stomp, and Impale on Madness come to mind). If you're at - or near - 100, you'll have wasted rage. Times like this I tend to pop Inner Rage to squeeze in more Heroic Strikes. I won't exactly HS on cooldown, but I'll generally burn off nearly all of my rage before that hit comes.
Thunderstruck increases the damage of 4 abilities you'll use as a tank. If you take Blood and Thunder, there's no reason not to pick up Thunderstruck. Rend is a decent portion of tank DPS, you'll be using Thunderclap to keep Rend and the attack speed debuff up, and it boosts the damage of Shockwave. Yes, Cleave may be the least used, but any time you've got an extra mob in range, you should use it instead of Heroic Strike. Especially if you're tanking both of them.
I have 0/2 Safeguard, because I rarely use Intervene. It might be handy on a couple of fights, but the last time I actively used it was to reduce our resto druid's threat on our first couple of kills on Shannox, since out Shannox tank occasionally bit late into the fight.
Blitz is more of a PvP talent. Any time I charged into I fight - not often, drives the healers nuts when you're suddenly out of range - I usually follow it up with Shockwave, which will hit more than just 1 extra mob.
Gag order is good for heroics where you need to pull a mob back, and there's no near spot to LoS. I'm only aware of 1 mob type in Hagara's trash that's affected by it in all of DS.
You mentioned yourself not using Intervene - It's more of an off-tank ability, especially in combination with Safeguard.
Most of your comments focus around the same thing - tank DPS. While prior to Cataclysm, tank dps was negligible, that's no longer the case, due to the massive AP boost we get from Vengeance. Before, if you couldn't beat the tank on the dps meter you were either dead, or maybe auto-attacking. Now, the tank might beat you, but in that case he probably outgears you quite a bit (or you need to work on your rotation/priority). Before, in ICC, the tank might be doing 25% of the lowest DPS (if my memory serves me correctly. I didn't tank in WotLK). Now, I do more than half of the lowest DPS. Usually around 10% of the DPS during a boss fight - more on fights like Yor'sahj if we get multiple Black jellos.
When the ship lifts, all bills are paid. No regrets.